Update Popovers to have close button #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a close button to the upper right corner. The close button appears both when a title is present and not, and changes the styling accordingly.
aabenoja
reviewed
Jun 28, 2017
| `; | ||
|
|
||
| const PopoverBodyContent = styled.div` | ||
| padding: 9px 14px; | ||
| `; | ||
|
|
||
| const DismissPopover = styled(DismissButton)` | ||
| background-color: ${props => (props.hasTitle ? colors.accent : 'none')}; |
There was a problem hiding this comment.
It looks like there are some discrepancies between the heights of the title and the close button that results in the title section background looking like this. I think the easiest fix would be to apply the background color to the PopoverHeader instead.
Changed popover header to have the background color, instead of the title and close button themselves
|
Can you execute |
jrios
approved these changes
Jun 28, 2017
|
Closes #31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added the 'X' dismiss button to the upper right corner of popovers, kind of along the lines of issue #31
The close button appears both when a title is present and not, and changes the styling of the close button and popover accordingly.
This is needed as Design wished to have a close button as part of all popovers as an obvious way to get out of them, and is required as part of an OE SEP story.
This fix currently only works for popovers that do not contain form elements, as there are some complications with
FocusTrapthat will need to be addressed in a separate pull request.